Skip to content

Deprecating no-arg informer-factory #2115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 31, 2022
Merged

Deprecating no-arg informer-factory #2115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ...ples/examples-release-13/src/main/java/io/kubernetes/client/examples/InformerExample.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,12 +41,16 @@ public static void main(String[] args) throws Exception {
apiClient.getHttpClient().newBuilder().readTimeout(0, TimeUnit.SECONDS).build();
apiClient.setHttpClient(httpClient);

SharedInformerFactory factory = new SharedInformerFactory();
SharedInformerFactory factory = new SharedInformerFactory(apiClient);

// Node informer
SharedIndexInformer<V1Node> nodeInformer =
factory.sharedIndexInformerFor(
(CallGeneratorParams params) -> {
// **NOTE**:
// The following "CallGeneratorParams" lambda merely generates a stateless
// HTTPs requests, the effective apiClient is the one specified when constructing
// the informer-factory.
return coreV1Api.listNodeCall(
null,
null,
Expand Down
6 changes: 5 additions & 1 deletion ...ples/examples-release-14/src/main/java/io/kubernetes/client/examples/InformerExample.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,12 +41,16 @@ public static void main(String[] args) throws Exception {
apiClient.getHttpClient().newBuilder().readTimeout(0, TimeUnit.SECONDS).build();
apiClient.setHttpClient(httpClient);

SharedInformerFactory factory = new SharedInformerFactory();
SharedInformerFactory factory = new SharedInformerFactory(apiClient);

// Node informer
SharedIndexInformer<V1Node> nodeInformer =
factory.sharedIndexInformerFor(
(CallGeneratorParams params) -> {
// **NOTE**:
// The following "CallGeneratorParams" lambda merely generates a stateless
// HTTPs requests, the effective apiClient is the one specified when constructing
// the informer-factory.
return coreV1Api.listNodeCall(
null,
null,
Expand Down
6 changes: 5 additions & 1 deletion ...ples/examples-release-15/src/main/java/io/kubernetes/client/examples/InformerExample.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,15 @@ public static void main(String[] args) throws Exception {
apiClient.getHttpClient().newBuilder().readTimeout(0, TimeUnit.SECONDS).build();
apiClient.setHttpClient(httpClient);

SharedInformerFactory factory = new SharedInformerFactory();
SharedInformerFactory factory = new SharedInformerFactory(apiClient);

// Node informer
SharedIndexInformer<V1Node> nodeInformer =
factory.sharedIndexInformerFor(
// **NOTE**:
// The following "CallGeneratorParams" lambda merely generates a stateless
// HTTPs requests, the effective apiClient is the one specified when constructing
// the informer-factory.
(CallGeneratorParams params) -> {
return coreV1Api.listNodeCall(
null,
Expand Down
2 changes: 2 additions & 0 deletions util/src/main/java/io/kubernetes/client/informer/SharedInformerFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,8 @@ public class SharedInformerFactory {
private ApiClient apiClient;

/** Constructor w/ default thread pool. */
/** DEPRECATE: In favor of explicit apiClient constructor to avoid misguiding */
@Deprecated
public SharedInformerFactory() {
this(Configuration.getDefaultApiClient().setReadTimeout(0), Executors.newCachedThreadPool());
}
Expand Down