Skip to content

Conversation

@yue9944882
Copy link
Member

@yue9944882 yue9944882 commented Jan 10, 2022

  1. replacing com.github.stefanbirkner/system-lambda w/ uk.org.webcompere/system-stubs-core, which is a dropin replacement for the former library that fixes the environment issue.

  2. adding a default contructor for Watch#Response to avoid gson's reflective dynamic constructor which violates the jdk16 restriction.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 10, 2022
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 10, 2022
@yue9944882 yue9944882 force-pushed the fix-java-16-compatibility-util branch from 17ea5b6 to c8c7f1f Compare January 10, 2022 09:23
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 10, 2022
@yue9944882 yue9944882 force-pushed the fix-java-16-compatibility-util branch 3 times, most recently from e83c09f to 42b85f1 Compare January 10, 2022 09:48
Signed-off-by: yue9944882 <291271447@qq.com>
@yue9944882 yue9944882 force-pushed the fix-java-16-compatibility-util branch from 42b85f1 to cefff96 Compare January 10, 2022 09:54
@yue9944882 yue9944882 changed the title [WIP] Fixes java 16 compability for "util" module Fixes java 16 compability Jan 10, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 10, 2022
@yue9944882
Copy link
Member Author

Fixes #1638

@brendandburns
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 10, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, yue9944882

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [brendandburns,yue9944882]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit b730016 into kubernetes-client:master Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants