Skip to content

Add macos to the matrix build. #2017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 10, 2022
Merged

Add macos to the matrix build. #2017

merged 3 commits into from
Mar 10, 2022

Conversation

brendandburns
Copy link
Contributor

@brendandburns brendandburns commented Dec 1, 2021 •
edited
Loading

Fixes #1218

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 1, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 1, 2021
@brendandburns brendandburns force-pushed the main branch 5 times, most recently from 57f5210 to 6161a56 Compare December 1, 2021 23:57
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 1, 2021
@brendandburns brendandburns force-pushed the main branch 2 times, most recently from 4107cf4 to 48b9ca3 Compare December 2, 2021 00:00
@brendandburns brendandburns reopened this Jan 22, 2022
@brendandburns brendandburns force-pushed the main branch 2 times, most recently from 2ede76e to fdea0ff Compare February 10, 2022 18:45
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 10, 2022
@brendandburns brendandburns mentioned this pull request Feb 10, 2022
Merged
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 11, 2022
@brendandburns
Copy link
Contributor Author

/hold waiting for flake fixes to merge

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 11, 2022
@brendandburns brendandburns force-pushed the main branch 2 times, most recently from 08338b1 to 5940b43 Compare March 8, 2022 21:14
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 8, 2022
@brendandburns
Copy link
Contributor Author

/hold remove

@yue9944882 this is ready for review. I changed one of the leader election tests, please check my changes and make sure they make sense.

@brendandburns brendandburns removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 9, 2022
yue9944882
yue9944882 reviewed Mar 10, 2022
View reviewed changes
extended/src/test/java/io/kubernetes/client/extended/leaderelection/LeaderElectionTest.java
@@ -274,6 +277,36 @@ private void assertHistory(List<String> history, String... expected) {
}
}

// assertWildcardHistory allows for an arbitrary number of repeated entries for an
// comparison with a '+' suffix. This allows for a semantic rather than literal
Copy link
Member

@yue9944882 yue9944882 Mar 10, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: in the sense of regex, i think * is more accurate than + here according to the description

yue9944882
yue9944882 reviewed Mar 10, 2022
View reviewed changes
Copy link
Member

@yue9944882 yue9944882 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think the ideal way to implement wildcard matching is by converting it to an FSM, but a minimal viable hard-coded wildcard also lgtm

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 10, 2022
@k8s-ci-robot k8s-ci-robot merged commit 48477c6 into kubernetes-client:master Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yue9944882 yue9944882 yue9944882 left review comments

Assignees

@yue9944882 yue9944882

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LeaderElectionTest is flaky
3 participants
@brendandburns @k8s-ci-robot @yue9944882