[fix] Avoid thread.sleep usage instead semaphore as replacement

[shharma-vipin]

Avoided Thread.sleep() and rather used TimedSemphore() to perform waiting and then let task happen
PR is to fix one of the issue under this PR umbrella #1223

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shharma-vipin
To complete the pull request process, please assign yue9944882 after the PR has been reviewed.
You can assign the PR to them by writing /assign @yue9944882 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[shharma-vipin]

/check-cla

[shharma-vipin]

/check-cla

[shharma-vipin]

/check-cla

[shharma-vipin]

/check-cla

[shharma-vipin]

Need help with cla/linuxfoundation. Not able to clear that github stage.

[shharma-vipin]

/assign @yue9944882

[shharma-vipin]

/unassign @yue9944882

[shharma-vipin]

/check-cla

[shharma-vipin]

/check-cla

[shharma-vipin]

cla bot - showing this as an error - "cla/linuxfoundation — shharma-vipin authorized, but 1 other problem".
However I am not able to locate logs to figure out the issue with this PR.
Any help on this ?

[shharma-vipin]

/check-cla

[shharma-vipin]

/check-sla

[gjkim42]

I think one of your commits has a different email address?
It would be better to squash those commits into one commit and set the author and the email address properly.

[brendandburns]

Thank you for sending in the PR.

However, there is not much difference between using a TimedSemaphore and just using Thread.sleep(...)

For this particular test, the right way to fix it would be to inject a mock Bandwidth object into the rate limiter and be able to adjust time without sleeping.

However, looking at the code I'm pretty skeptical that this test will ever be racy, so it's probably not worth the effort.

There are a number of other places e.g.
https://github.com/kubernetes-client/java/blob/master/util/src/test/java/io/kubernetes/client/informer/cache/SharedProcessorTest.java#L55

Which would be better to fix if you want to fix one of them.

Thanks!

[yue9944882]

@shharma-vipin ur commit 7d13b01 is authored by vipinsharma@Vipins-MacBook-Pro.local which is why ur pr fails cla check

[shharma-vipin]

As per one of the review comment & looking at effectiveness of this change set, closing this PR