-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make compatible and bump to LTS 12.24 #29
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ababkin If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -44,7 +44,7 @@ library | |||
, http-client >=0.5 && <0.6 | |||
, http-client-tls | |||
, http-media >= 0.4 && < 0.8 | |||
, http-types >=0.8 && <0.12 | |||
, http-types >=0.8 && <0.13 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is auto-generated by swagger-codegen. To make a change, we need to modify the source at https://github.com/swagger-api/swagger-codegen/blob/master/modules/swagger-codegen/src/main/resources/haskell-http-client/haskell-http-client.cabal.mustache.
makes sense, thank you
…On Mon, Dec 17, 2018 at 5:04 PM Shimin Guo ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In kubernetes/kubernetes.cabal
<#29 (comment)>
:
> @@ -44,7 +44,7 @@ library
, http-client >=0.5 && <0.6
, http-client-tls
, http-media >= 0.4 && < 0.8
- , http-types >=0.8 && <0.12
+ , http-types >=0.8 && <0.13
This file is auto-generated by swagger-codegen. To make a change, we need
to modify the source at
https://github.com/swagger-api/swagger-codegen/blob/master/modules/swagger-codegen/src/main/resources/haskell-http-client/haskell-http-client.cabal.mustache
.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#29 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAO_VOov4GAlwzLpF5JMPSonKV5RDJWHks5u6BUBgaJpZM4ZXLce>
.
|
I PR-ed latest LTS to swagger-codegen: swagger-api/swagger-codegen#9209 |
great thanks |
No description provided.