feat: introduce openapi-generator #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
/lgtm Many thanks! |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, tomplus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces openapi-generator as a replacement for swagger-codegen (issue #93).
There are 3 commits for better readability:
Move files related to the
swagger-codegento a separate folder and update all clients to use it. I tested it on python, python-asyncio clients - no differences from generated codeAdd openapi-generator - files are very similar but I expected that it will change in the future (new options, switches, names etc.)
Switch python-asyncio client to use openapi-generator - generated files are committed to a branch and differences can be examined in this PR: feat: use openapi-generator to generate client tomplus/kubernetes_asyncio#58
There are some breaking changes which I'll have to cope with that but it looks very promising.
More information about differences between generators you can find in a migration guide.
I'm looking forward to your opinion. Can we switch official clients to the new generator? Of course not in this PR but in general. It'll be a breaking change and maintainers should handle and announce it properly.
Thanks!
PTAL: @brendandburns @mbohlool @roycaihw