Skip to content

Reuse const strings and expose PluralName #811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 29, 2022
Merged

Reuse const strings and expose PluralName #811

merged 2 commits into from
Mar 29, 2022

Conversation

stan-sz
Copy link
Contributor

@stan-sz stan-sz commented Mar 28, 2022

Both in ModelExtensions.cs

@stan-sz
Reuse const strings and expose PluralName
7388d59 
Both in ModelExtensions.cs
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: stan-sz
To complete the pull request process, please assign krabhishek8260 after the PR has been reviewed.
You can assign the PR to them by writing /assign @krabhishek8260 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 28, 2022
@stan-sz
Copy link
Contributor Author

stan-sz commented Mar 28, 2022

/assign tg123

@tg123
Copy link
Member

tg123 commented Mar 29, 2022

/LGTM

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 29, 2022
@tg123 tg123 merged commit 93c50b4 into kubernetes-client:master Mar 29, 2022
@tg123 tg123 mentioned this pull request Apr 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendandburns brendandburns Awaiting requested review from brendandburns

@krabhishek8260 krabhishek8260 Awaiting requested review from krabhishek8260

Assignees

@tg123 tg123

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stan-sz @k8s-ci-robot @tg123