Version 17.0 + Generate 1.33 #1626
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
approved
… update target framework to net9.0
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
…kages.props and LibKubernetesGenerator.target
…onary type declaration in Program.cs
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the SDK to version 17.0 with generated components using version 1.33, removes AutoMapper support, and cleans up code style across examples while upgrading dependencies.
- Removed files related to AutoMapper (VersionConverter.cs, KubernetesVersionComparer.cs, AutoMapperModelVersionConverter.cs).
- Updated asynchronous calls to include ConfigureAwait(false) for improved responsiveness.
- Made minor style and documentation improvements in example projects.
Reviewed Changes
Copilot reviewed 25 out of 30 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/KubernetesClient.ModelConverter/AutoMapper/VersionConverter.cs | Removed AutoMapper conversion functionality per removal of AutoMapper support. |
| src/KubernetesClient.ModelConverter/AutoMapper/KubernetesVersionComparer.cs | Removed version comparer functionality as part of deprecating AutoMapper support. |
| src/KubernetesClient.ModelConverter/AutoMapper/AutoMapperModelVersionConverter.cs | Removed the version converter implementation using AutoMapper. |
| examples/yaml/Program.cs | Updated async call patterns and minor type style adjustment. |
| examples/workerServiceDependencyInjection/Worker.cs and Program.cs | Improved XML documentation and added ConfigureAwait(false) for async calls. |
| examples/watch/Program.cs | Introduced ConfigureAwait(false) in asynchronous enumerable call and added warning suppression for unused private members. |
| examples/restart/Program.cs, portforward, patch-aot, openTelemetryConsole, csrApproval, cp/Cp.cs | Applied ConfigureAwait(false) for async operations and did minor style fixes. |
| README.md | Updated SDK version and supported .NET targets. |
| .github/workflows/buildtest.yaml | Upgraded dotnet SDK version from 8.0.x to 9.0.x. |
Files not reviewed (5)
- Directory.Packages.props: Language not supported
- csharp.settings: Language not supported
- examples/Directory.Build.props: Language not supported
- examples/Directory.Build.targets: Language not supported
- src/KubernetesClient.ModelConverter/KubernetesClient.ModelConverter.csproj: Language not supported
Comments suppressed due to low confidence (1)
examples/watch/Program.cs:19
- Using ConfigureAwait(false) directly on an IAsyncEnumerable in an await foreach loop may cause compilation issues. Consider removing ConfigureAwait(false) from the asynchronous enumerable.
await foreach (var (type, item) in podlistResp.WatchAsync<V1Pod, V1PodList>().ConfigureAwait(false))
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, tg123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
lgtm
|
@brendandburns nuget token expired, need a new one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1 Generated with 1.33
2 AutoMapper support removed due to AutoMapper is going commercial
3 example style cleanup
4 dependencies upgraded
5