Skip to content

Improve docs and naming of LeaderElector methods. #1468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 6, 2023
Merged

Improve docs and naming of LeaderElector methods. #1468

merged 2 commits into from
Dec 6, 2023
+39 −8

Conversation

PSanetra
Copy link
Contributor

@PSanetra PSanetra commented Dec 5, 2023

Improves docs and naming of LeaderElector methods. Also introduces LeaderElector.AcquireLeadershipForever().

Fixes #1467

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 5, 2023
tg123
tg123 reviewed Dec 6, 2023
View reviewed changes
@PSanetra PSanetra force-pushed the improve-LeaderElector-docs branch from 585c900 to 09fd080 Compare December 6, 2023 10:42
@PSanetra
Improve docs and naming of LeaderElector methods. Also introduce `L…
a023aba 
…eaderElector.RunAndTryToHoldLeadershipForeverAsync()`
@PSanetra PSanetra force-pushed the improve-LeaderElector-docs branch from 09fd080 to a023aba Compare December 6, 2023 10:42
tg123
tg123 approved these changes Dec 6, 2023
View reviewed changes
Copy link
Member

@tg123 tg123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

/LGTM

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 6, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: PSanetra, tg123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 6, 2023
tg123
tg123 reviewed Dec 6, 2023
View reviewed changes
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 6, 2023
@tg123
Copy link
Member

tg123 commented Dec 6, 2023

/LGTM

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 6, 2023
@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2023 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (master@abf5da9). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...c/KubernetesClient/LeaderElection/LeaderElector.cs 0.00% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff            @@
##             master    #1468   +/-   ##
=========================================
  Coverage          ?   70.47%           
=========================================
  Files             ?       89           
  Lines             ?     2655           
  Branches          ?      554           
=========================================
  Hits              ?     1871           
  Misses            ?      784           
  Partials          ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@k8s-ci-robot k8s-ci-robot merged commit 109ca1d into kubernetes-client:master Dec 6, 2023
This was referenced Sep 17, 2025
Open
Closed
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tg123 tg123 tg123 approved these changes

@brendandburns brendandburns Awaiting requested review from brendandburns

Assignees

@tg123 tg123

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document expected behavior of LeaderElector.RunAsync()
4 participants
@PSanetra @k8s-ci-robot @tg123 @codecov-commenter