-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add static up support for KubeVirt in KubeOVN #1851
Conversation
/approve |
@moadqassem: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/approve |
/lgtm |
LGTM label has been added. Git tree hash: 72904c7bd4f154d2069011716964f8628f952b8b
|
Signed-off-by: moadqassem <moad.qassem@gmail.com>
/approve |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yaa110 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM label has been added. Git tree hash: c3dba416b5754e61ca578dd06833db4eac2f3476
|
What this PR does / why we need it:
Enabling the live migration of KubeVirt VMs by default. This would enable us to get a static ip address when using KubeOVN as a CNI. Another PR would actually fine tune this feature based on machine deployment configs.
Which issue(s) this PR fixes:
Fixes #
What type of PR is this?
/kind feature
Special notes for your reviewer:
Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation: