Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add static up support for KubeVirt in KubeOVN #1851

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

moadqassem
Copy link
Member

What this PR does / why we need it:
Enabling the live migration of KubeVirt VMs by default. This would enable us to get a static ip address when using KubeOVN as a CNI. Another PR would actually fine tune this feature based on machine deployment configs.

Which issue(s) this PR fixes:

Fixes #

What type of PR is this?
/kind feature

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

allow live migration by default

Documentation:

None

@kubermatic-bot kubermatic-bot added kind/feature Categorizes issue or PR as related to a new feature. docs/none Denotes a PR that doesn't need documentation (changes). release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 27, 2024
@yaa110
Copy link

yaa110 commented Aug 27, 2024

/approve

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 27, 2024
@kubermatic-bot
Copy link
Contributor

@moadqassem: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-machine-controller-e2e-kubevirt 82d7d00 link true /test pull-machine-controller-e2e-kubevirt

Full PR test history

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@yaa110
Copy link

yaa110 commented Aug 28, 2024

/approve

@yaa110
Copy link

yaa110 commented Aug 28, 2024

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 28, 2024
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 72904c7bd4f154d2069011716964f8628f952b8b

Signed-off-by: moadqassem <moad.qassem@gmail.com>
@kubermatic-bot kubermatic-bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 28, 2024
@yaa110
Copy link

yaa110 commented Aug 28, 2024

/approve

@yaa110
Copy link

yaa110 commented Aug 28, 2024

/lgtm

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yaa110

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 28, 2024
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c3dba416b5754e61ca578dd06833db4eac2f3476

@kubermatic-bot kubermatic-bot merged commit 24e281f into kubermatic:main Aug 28, 2024
12 checks passed
@moadqassem moadqassem deleted the kv-fix-ips branch August 28, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants