Skip to content

Change the quota calculations to use the binary system instead of the decimal system #7729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ahmadhamzh wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Change the quota calculations to use the binary system instead of the decimal system #7729

ahmadhamzh wants to merge 2 commits into from
+99 −64

Conversation

@ahmadhamzh
Copy link
Contributor

@ahmadhamzh ahmadhamzh commented Dec 11, 2025 •
edited
Loading

What this PR does / why we need it:
This PR updates the resource quota calculation logic to use binary units (IEC) instead of decimal units (SI).

Which issue(s) this PR fixes:
Fixes #7715

What type of PR is this?
/kind bug

Special notes for your reviewer:
there is some issues in getting the global usage for Anexia, Kubevirt and AWS providers,
a ticket has been created here

Does this PR introduce a user-facing change? Then add your Release Note here:

Updated resource quota calculations to use binary units (base-1024).

Documentation:

NONE

@kubermatic-bot kubermatic-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/docs-needed Indicates that a PR should not merge because it's missing one of the documentation labels. labels Dec 11, 2025
@kubermatic-bot
Copy link
Contributor

kubermatic-bot commented Dec 11, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubermatic-bot kubermatic-bot added sig/api Denotes a PR or issue as being assigned to SIG API. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 11, 2025
@ahmadhamzh ahmadhamzh force-pushed the 7715-quota-calculations-should-be-in-GiB branch from e22cda8 to 1468891 Compare December 11, 2025 16:14
@ahmadhamzh ahmadhamzh marked this pull request as ready for review December 11, 2025 16:15
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 11, 2025
@ahmadhamzh ahmadhamzh changed the title Change the quota calculations to use the binary system instead of the decimal system WIP Change the quota calculations to use the binary system instead of the decimal system Dec 11, 2025
@kubermatic-bot kubermatic-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 11, 2025
@ahmadhamzh ahmadhamzh force-pushed the 7715-quota-calculations-should-be-in-GiB branch from 1468891 to 3d4b55a Compare December 24, 2025 05:50
@kubermatic-bot
Copy link
Contributor

kubermatic-bot commented Dec 24, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from ahmadhamzh. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 24, 2025
@ahmadhamzh
Copy link
Contributor Author

ahmadhamzh commented Dec 24, 2025

there is some changes needed from backend for Anexia, Kubevirt and AWS providers,
a ticket has been created here

@ahmadhamzh ahmadhamzh force-pushed the 7715-quota-calculations-should-be-in-GiB branch from 3d4b55a to 543fd61 Compare December 29, 2025 04:23
@ahmadhamzh
Copy link
Contributor Author

ahmadhamzh commented Dec 29, 2025

/retest

@ahmadhamzh ahmadhamzh force-pushed the 7715-quota-calculations-should-be-in-GiB branch from 543fd61 to e07a633 Compare December 29, 2025 09:28
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. docs/none Denotes a PR that doesn't need documentation (changes). and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/docs-needed Indicates that a PR should not merge because it's missing one of the documentation labels. labels Dec 29, 2025
@ahmadhamzh ahmadhamzh force-pushed the 7715-quota-calculations-should-be-in-GiB branch from e07a633 to b424fb6 Compare December 29, 2025 09:47
@ahmadhamzh ahmadhamzh changed the title WIP Change the quota calculations to use the binary system instead of the decimal system Change the quota calculations to use the binary system instead of the decimal system Dec 29, 2025
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 29, 2025
@ahmadhamzh ahmadhamzh changed the title Change the quota calculations to use the binary system instead of the decimal system WIP Change the quota calculations to use the binary system instead of the decimal system Dec 31, 2025
@kubermatic-bot kubermatic-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 31, 2025
@ahmadhamzh ahmadhamzh changed the title WIP Change the quota calculations to use the binary system instead of the decimal system Change the quota calculations to use the binary system instead of the decimal system Jan 5, 2026
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api Denotes a PR or issue as being assigned to SIG API. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

project quota calculations should be done with Storage units (MiB, GiB) instead of decimal units MB, GB etc

2 participants

@ahmadhamzh @kubermatic-bot