Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mock E2E tests for AWS #3708

Merged
merged 27 commits into from
Oct 6, 2021
Merged

Conversation

maciaszczykm
Copy link
Contributor

@maciaszczykm maciaszczykm commented Sep 21, 2021

What this PR does / why we need it

Creates base for completing #3712.

Special notes for your reviewer

  • After testing some custom libraries to mock WebSocket connections in tests I've decided to add a way to switch app to legacy mode without WebSocket connections. It simplifies the code a lot and then we do not rely on some unknown solutions that have their issues and not much support. Cypress already has adding WebSocket support on their roadmap [1] and I'd stick to that. Until then we can use pooling instead.

[1] cypress-io/cypress#2492, cypress-io/cypress#7655 and cypress-io/cypress#199

Release note

NONE

Add get projects fixture and mock
@kubermatic-bot kubermatic-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 21, 2021
@codecov
Copy link

codecov bot commented Sep 21, 2021

Codecov Report

Merging #3708 (cf03953) into master (fc5fbbe) will increase coverage by 0.14%.
The diff coverage is 17.64%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3708      +/-   ##
==========================================
+ Coverage   52.25%   52.40%   +0.14%     
==========================================
  Files         284      284              
  Lines       10229    10238       +9     
  Branches     1075     1077       +2     
==========================================
+ Hits         5345     5365      +20     
+ Misses       4879     4869      -10     
+ Partials        5        4       -1     
Impacted Files Coverage Δ
src/environments/environment.ts 100.00% <ø> (ø)
src/app/core/services/user.ts 37.09% <17.64%> (-4.42%) ⬇️
src/app/project/component.ts 65.10% <0.00%> (+6.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc5fbbe...cf03953. Read the comment docs.

@kubermatic-bot kubermatic-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 21, 2021
@maciaszczykm maciaszczykm changed the title Mock E2E tests [WIP] Mock E2E tests Sep 22, 2021
@kubermatic-bot kubermatic-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 22, 2021
@kubermatic-bot kubermatic-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 22, 2021
@kubermatic-bot kubermatic-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 29, 2021
@maciaszczykm maciaszczykm changed the title [WIP] Mock E2E tests Mock E2E tests for AWS Oct 5, 2021
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 5, 2021
@maciaszczykm
Copy link
Contributor Author

/assign @kgroschoff @floreks

@maciaszczykm
Copy link
Contributor Author

/retest

1 similar comment
@maciaszczykm
Copy link
Contributor Author

/retest

@kubermatic-bot
Copy link
Contributor

kubermatic-bot commented Oct 6, 2021

@maciaszczykm: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
pre-dashboard-test-mocks-e2e b4f73ec link /test pre-dashboard-test-mocks-e2e

Full PR test history

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@maciaszczykm
Copy link
Contributor Author

/retest

@floreks
Copy link
Contributor

floreks commented Oct 6, 2021

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 6, 2021
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 77ea73ec4c5267a2d477da6ae5b9e72ca494497a

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks, maciaszczykm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [floreks,maciaszczykm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot merged commit a5fde00 into kubermatic:master Oct 6, 2021
@maciaszczykm maciaszczykm deleted the mock-e2e-tests branch October 6, 2021 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants