fix syncing repository visibility

kubermatic-labs · Jun 17, 2020 · 34b9199 · 34b9199
1 parent 660046f
commit 34b9199
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/pkg/quay/repository.go b/pkg/quay/repository.go
@@ -35,6 +35,14 @@ func (r *Repository) FullName() string {
 	return r.Namespace + "/" + r.Name
 }
 
+func (r *Repository) Visibility() RepositoryVisibility {
+	if r.IsPublic {
+		return Public
+	}
+
+	return Private
+}
+
 type getRepositoriesReponse struct {
 	Repositories []Repository `json:"repositories"`
 }

diff --git a/pkg/sync/sync.go b/pkg/sync/sync.go
@@ -249,9 +249,7 @@ func syncRepositories(ctx context.Context, config *config.Config, client *quay.C
 }
 
 func syncRepository(ctx context.Context, client *quay.Client, repo quay.Repository, repoConfig *config.RepositoryConfig) error {
-	// ensure repos are not public if they are configured to be private (phrase it like this
-	// just in case quay ever introduces a third visibility state)
-	if repo.IsPublic && repoConfig.Visibility != quay.Public {
+	if repo.Visibility() != repoConfig.Visibility {
 		log.Printf("    - set visibility to %s", repoConfig.Visibility)
 		if err := client.ChangeRepositoryVisibility(ctx, repo.FullName(), repoConfig.Visibility); err != nil {
 			return fmt.Errorf("failed to set visibility: %v", err)