build(deps): bump github.com/docker/docker #5104
Conversation
Bumps github.com/docker/docker from 28.0.3+incompatible to 28.0.4+incompatible. Signed-off-by: zhangzujian <zhangzujian.7@gmail.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @zhangzujian, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request bumps the version of github.com/docker/docker from 28.0.3+incompatible to 28.0.4+incompatible. It also updates other dependencies in the go.mod and go.sum files, including golangci-lint, cel.dev/expr, github.com/andybalholm/brotli, github.com/elazarl/goproxy, github.com/go-viper/mapstructure/v2, github.com/lunixbochs/struc, github.com/opencontainers/runc, github.com/opencontainers/selinux, github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring, github.com/spf13/afero, github.com/spf13/viper, github.com/tklauser/go-sysconf, github.com/tklauser/numcpus, and gocv.io/x/gocv. The changes are primarily dependency updates.
Highlights
- Dependency Update: The primary focus of this PR is to update the github.com/docker/docker dependency from version 28.0.3+incompatible to 28.0.4+incompatible.
- golangci-lint Version Bump: The PR also updates the golangci-lint version in
.github/workflows/build-x86-image.yamlfrom v2.0.1 to v2.0.2. - Indirect Dependency Updates: Several indirect dependencies in
go.modandgo.sumhave been updated, includingcel.dev/expr,github.com/andybalholm/brotli, and others.
Changelog
Click here to see the changelog
- .github/workflows/build-x86-image.yaml
- Updated GOLANGCI_LINT_VERSION from 'v2.0.1' to 'v2.0.2'.
- go.mod
- Updated github.com/docker/docker from v28.0.3+incompatible to v28.0.4+incompatible.
- Updated cel.dev/expr from v0.21.2 to v0.22.1.
- Updated github.com/andybalholm/brotli from v1.1.0 to v1.1.1.
- Updated github.com/elazarl/goproxy from v1.7.0 to v1.7.2.
- Added github.com/go-viper/mapstructure/v2 v2.2.1.
- Removed github.com/hashicorp/hcl v1.0.0.
- Updated github.com/lunixbochs/struc from v0.0.0-20200707160740-784aaebc1d40 to v0.0.0-20241101090106-8d528fa2c543.
- Removed github.com/magiconair/properties v1.8.9.
- Updated github.com/opencontainers/runc from v1.2.5 to v1.2.6.
- Updated github.com/opencontainers/selinux from v1.11.1 to v1.12.0.
- Updated github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring from v0.80.1 to v0.81.0.
- Updated github.com/spf13/afero from v1.12.0 to v1.14.0.
- Updated github.com/spf13/viper from v1.19.0 to v1.20.0.
- Updated github.com/tklauser/go-sysconf from v0.3.14 to v0.3.15.
- Updated github.com/tklauser/numcpus from v0.9.0 to v0.10.0.
- Updated gocv.io/x/gocv from v0.40.0 to v0.41.0.
- Removed gopkg.in/ini.v1 v1.67.0.
- Updated k8s.io/cri-client from v0.0.0 to v0.32.3.
- Updated k8s.io/dynamic-resource-allocation from v0.0.0 to v0.32.3.
- Updated k8s.io/kube-scheduler from v0.0.0 to v0.32.3.
- Updated k8s.io/mount-utils from v0.0.0 to v0.32.3.
- go.sum
- Updated checksums for all updated dependencies.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Did you know?
The name 'Docker' comes from the term 'docker', which refers to a person who loads and unloads ships, reflecting the software's ability to package and deploy applications.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request bumps several dependencies in the go.mod and go.sum files, as well as updates the golangci-lint version in the build workflow. Overall, the changes seem straightforward and necessary for keeping the project up-to-date with the latest versions of its dependencies.
Summary of Findings
- Dependency Updates: The pull request updates various dependencies, including github.com/docker/docker, cel.dev/expr, github.com/andybalholm/brotli, github.com/elazarl/goproxy, github.com/go-viper/mapstructure/v2, github.com/lunixbochs/struc, github.com/opencontainers/runc, github.com/opencontainers/selinux, github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring, github.com/spf13/afero, github.com/spf13/viper, gocv.io/x/gocv, and k8s.io/cri-client. These updates should be verified for compatibility and potential breaking changes.
- GolangCI-Lint Version Update: The pull request updates the golangci-lint version in the build workflow. It's important to ensure that the updated linter doesn't introduce new warnings or errors that need to be addressed.
- Removed Dependencies: The pull request removes hashicorp/hcl and gopkg.in/ini.v1 dependencies. It's important to verify that these dependencies are no longer needed and that their removal doesn't break any functionality.
Merge Readiness
The pull request appears to be a routine dependency update. However, due to the potential for breaking changes or compatibility issues with dependency updates, I recommend that the author verify that all tests pass and that the application functions as expected before merging. Additionally, I recommend that the author verify that the removed dependencies are no longer needed and that their removal doesn't break any functionality. I am unable to approve this pull request, and users should have others review and approve this code before merging.
Pull Request Test Coverage Report for Build 14073907376Details
💛 - Coveralls |
dosubot
bot
added
the
size:M
Bumps github.com/docker/docker from 28.0.3+incompatible to 28.0.4+incompatible.
Pull Request
What type of this PR
Examples of user facing changes:
Which issue(s) this PR fixes
Fixes #(issue-number)