fix(operator): Use Patch to update TrainJob status#3009
fix(operator): Use Patch to update TrainJob status#3009google-oss-prow[bot] merged 1 commit intokubeflow:masterfrom
Conversation
Signed-off-by: Antonin Stefanutti <antonin@stefanutti.fr>
Pull Request Test Coverage Report for Build 19738925925Details
💛 - Coveralls |
| // TODO(astefanutti): Consider using SSA once controller-runtime client has SSA support | ||
| // for sub-resources. See: https://github.com/kubernetes-sigs/controller-runtime/issues/3183 |
There was a problem hiding this comment.
AFAIK, the SSA sub resource support has already been done: kubernetes-sigs/controller-runtime#3321
Is this comment right?
There was a problem hiding this comment.
Oh, this has not been released, yet.
|
Thank you! /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick release-2.1 |
|
@tenzen-y: new pull request created: #3012 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Antonin Stefanutti <antonin@stefanutti.fr>
What this PR does / why we need it:
It happens some status update are missed for a TrainJob when the owned JobSet rapidly updates because of conflicts.
This PR changes to patch TrainJob status instead of update to avoid those conflicts.
Checklist: