Skip to content

Fix MPI Test runnable errors #2570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2025
Merged

Conversation

tenzen-y
Copy link
Member

What this PR does / why we need it:

The Validate() function is no more acceptable for JobSetTemplate as a dedicated argument. However, when we merge #2555, unfortunately added the no available arguments to our MPI UTs

# github.com/kubeflow/trainer/pkg/runtime/framework/plugins/mpi [github.com/kubeflow/trainer/pkg/runtime/framework/plugins/mpi.test]
Error: pkg/runtime/framework/plugins/mpi/mpi_test.go:821:93: too many arguments in call to p.(framework.CustomValidationPlugin).Validate
	have (nil, *"github.com/kubeflow/trainer/pkg/runtime".Info, *"github.com/kubeflow/trainer/pkg/apis/trainer/v1alpha1".TrainJob, *"github.com/kubeflow/trainer/pkg/apis/trainer/v1alpha1".TrainJob)
	want (*"github.com/kubeflow/trainer/pkg/runtime".Info, *"github.com/kubeflow/trainer/pkg/apis/trainer/v1alpha1".TrainJob, *"github.com/kubeflow/trainer/pkg/apis/trainer/v1alpha1".TrainJob)

https://github.com/kubeflow/trainer/actions/runs/14106238715/job/39513354634#step:4:91

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #

Checklist:

  • Docs included if any changes are user facing

Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
@tenzen-y
Copy link
Member Author

/assign @kubeflow/wg-training-leads @astefanutti

Copy link
Contributor

@astefanutti astefanutti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tenzen-y!
/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich, astefanutti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 3ef89f4 into kubeflow:master Mar 27, 2025
18 checks passed
@tenzen-y tenzen-y deleted the fix-test-bug branch March 27, 2025 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants