Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KEP-2170: Add TrainJob and TrainingRuntime APIs #2223

Merged
merged 12 commits into from
Aug 27, 2024
Merged

KEP-2170: Add TrainJob and TrainingRuntime APIs #2223

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
6865663
KEP-2170: Add TrainJob and TrainingRuntime APIs
andreyvelich Aug 15, 2024
ed830c8
Fix TrainJobList
andreyvelich Aug 16, 2024
66e7049
Register APIs with scheme
andreyvelich Aug 16, 2024
bfa1f20
Add SchemeGroupVersion
andreyvelich Aug 16, 2024
2bf13c9
Fix TrainingRuntimeSpec omitempty
andreyvelich Aug 19, 2024
72a933e
Generate manifests only for v1
andreyvelich Aug 19, 2024
9d0a686
Fix pointers for APIs
andreyvelich Aug 20, 2024
880560c
Run code-gen
andreyvelich Aug 20, 2024
49a004c
Use pointer for MPIImplementation
andreyvelich Aug 21, 2024
c28a166
Update the JobSetTemplate API
andreyvelich Aug 22, 2024
06e7653
Rename PodGroupPolicy and MLPolicy APIs
andreyvelich Aug 26, 2024
7aa4094
Update comments
andreyvelich Aug 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use pointer for MPIImplementation 
Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
  • Loading branch information
@andreyvelich
andreyvelich committed Aug 21, 2024
commit 49a004c0c5ccfad9dc48d7fbafa6d35028644cbe
2 changes: 1 addition & 1 deletion pkg/apis/kubeflow.org/v2alpha1/trainingruntime_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ type MPISpec struct {

// Implementation name for the MPI to create the appropriate hostfile.
// Defaults to OpenMPI.
MPIImplementation MPIImplementation `json:"mpiImplementation,omitempty"`
MPIImplementation *MPIImplementation `json:"mpiImplementation,omitempty"`

// Directory where SSH keys are mounted.
SSHAuthMountPath *string `json:"SSHAuthMountPath,omitempty"`
Expand Down
5 changes: 5 additions & 0 deletions pkg/apis/kubeflow.org/v2alpha1/zz_generated.deepcopy.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading