Update go-license-tool #553
Conversation
|
@Bobgy could you review this please? |
There was a problem hiding this comment.
@zhenghuiwang Thanks for the rewrite! Extra examples and process documentation makes this super clear! Great work!
only left some minor comments
| for line in f: | ||
| parts = line.strip().split(',') | ||
| _, license_url, license_type, *_ = parts | ||
| if license_url in mapping and license_type == 'Other': |
There was a problem hiding this comment.
For the purpose of the CI workflow, I think this script should better throw an error if some library has license_type 'Other', but it is not in the mapping.
This guards against incomplete patch file.
There was a problem hiding this comment.
Good suggestion! Done.
|
|
||
| Reminder: don't forget to put the library itself into `dep.txt`. |
There was a problem hiding this comment.
Shall we keep this reminder?
For redistributing 3rd party images, we need the library itself's license.
For distributing first party images, I think it's better we deliver our own license too.
There was a problem hiding this comment.
Done. Added to line 43
|
/lgtn |
|
/lgtm |
|
/approve
…On Mon, Jan 6, 2020 at 20:37 Yuan (Bob) Gong ***@***.***> wrote:
/lgtm
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#553?email_source=notifications&email_token=AB7BSKMBMADIIGQCWXN7LTLQ4QBH5A5CNFSM4KCH3ULKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIHVK2Q#issuecomment-571430250>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB7BSKIVCNYELQWN3TOC45DQ4QBH5ANCNFSM4KCH3ULA>
.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zhenghuiwang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Update go-license-tool with more detailed instructions and one new script.
This change is