update code to fix error on termination time when using sidecar #867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liyinan926
reviewed
Apr 11, 2020
liyinan926
approved these changes
Apr 11, 2020
jrj-d
added a commit
to jrj-d/spark-on-k8s-operator
that referenced
this pull request
May 28, 2020
Hey there, We are [Data Mechanics](https://www.datamechanics.co/), a managed Spark platform deployed on Kubernetes. We use the spark-operator in the background; congrats for the great work by the way! We have already made small contributions to the project (see kubeflow#867) and hope to do more! Cheers, Julien
This was referenced May 28, 2020
jbhalodia-slack
pushed a commit
to jbhalodia-slack/spark-operator
that referenced
this pull request
Oct 4, 2024
…flow#867) * update code to fix error on termination time when using sidecar * fix and add new tests * fixup! update code to fix error on termination time when using sidecar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This PR is related to issue #841
Following the discussion on this issue, i've implemented
option 2Specifically, I've introduced a new State Machine specific to the Driver that allow finer grain detection of application end when using sidecar containers
This is also compatible with kubernetes sidecar implementation on version 1.18
I've also updated the tests to cover sidecar cases
PS: for the review the commit are scoped
bfacfe9 is logic only
dbd2f21 is to fix and update tests