New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prometheus: Fixed separator escaping. Renamed field #421

Merged

liyinan926 merged 2 commits into kubeflow:master from lightbend:promimprov

Feb 22, 2019

Contributor

yuchaoran2011 commented Feb 22, 2019

Fixed the escaping of the dot separator between the namespace and the app name in the metric names.
Changed app_name to app_id to be consistent with the naming in the Spark Prometheus configuration.

yuchaoran2011 added 2 commits

February 21, 2019 22:06


          Fixed separator escaping. Renamed field

1c4ddda


          Fixed test failure

40a103d

liyinan926 merged commit 35c5778 into kubeflow:master

yuchaoran2011 deleted the promimprov branch

February 22, 2019 16:54

oliver-tarrant-tessella mentioned this pull request

Metrics format changed? #381

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet