Fixed webhook #342
Merged
Fixed webhook #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le instances of the operator running in the same cluster
liyinan926
reviewed
Dec 10, 2018
|
@yuchaoran2011 the latest image |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR needs to be merged first and the image
gcr.io/spark-operator/spark-operator:v2.4.0-v1alpha1-latestneeds to be rebuilt and pushed. After that I'll make a PR with these changes against helm/charts repo. Because only after the new image is pushed will the helm/charts CI pass on my PR.I also made the MutatingWebhookConfiguration name configurable. We have a use case where two teams each has an operator instance running in their own namespace. The team who installs the operator later would override the webhook configuration of the team who deployed earlier.
Fixed #335