#1143 Helm issues while deploying using argocd #1145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
@googlebot I signed it! |
…and CRD validation fixes A new version of the helm chart should be released which contains configurable webhook-cleanup-job annotations, as the helm-hook pre-update doesn't work with argocd, and the CRD fixes which are failing validation. Signed-off-by: Tom Hellier <me@tomhellier.com>
tandrup
added a commit
to tandrup/spark-on-k8s-operator
that referenced
this pull request
Feb 5, 2021
This enables users to install the chart using ArgoCD without setting special values. This solves kubeflow#1143 without requiring setting special values in values.yaml like the PR kubeflow#1145 requires.
liyinan926
pushed a commit
that referenced
this pull request
Mar 7, 2021
jbhalodia-slack
pushed a commit
to jbhalodia-slack/spark-operator
that referenced
this pull request
Oct 4, 2024
…tations and CRD validation fixes (kubeflow#1145) A new version of the helm chart should be released which contains configurable webhook-cleanup-job annotations, as the helm-hook pre-update doesn't work with argocd, and the CRD fixes which are failing validation. Signed-off-by: Tom Hellier <me@tomhellier.com>
jbhalodia-slack
pushed a commit
to jbhalodia-slack/spark-operator
that referenced
this pull request
Oct 4, 2024
This enables users to install the chart using ArgoCD without setting special values. This solves kubeflow#1143 without requiring setting special values in values.yaml like the PR kubeflow#1145 requires.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some helm issues while deploying using argocd, namely a CRD which doesn't pass validation, and make the webhook-cleanup-job annotations configurable
This should close issue #1143