Skip to content

add e2e notebook tests #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

briangallagher
Copy link

What this PR does / why we need it:
Add e2e tests to ensure that the sdk is still compatible with the latest version of trainer.

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):

Fixes #18

Checklist:

  • Docs included if any changes are user facing

Signed-off-by: Brian Gallagher <briangal@gmail.com>
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign andreyvelich for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@briangallagher
Copy link
Author

@andreyvelich Can you approve this workflow?

@Electronic-Waste
Copy link
Member

/ok-to-test
/rerun-all

Makefile Outdated
LOCALBIN ?= $(PROJECT_DIR)/bin

# Tool versions
KIND_VERSION ?= $(shell go list -m -f '{{.Version}}' sigs.k8s.io/kind)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have go.mod in sdk repo, could just set a fallback value?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, will set to current version, v0.27.0, thanks

Comment on lines 76 to 81
NOTEBOOK_INPUT=./examples/training/pytorch/image-classification/mnist.ipynb \
NOTEBOOK_OUTPUT=./artifacts/notebooks/${{ matrix.kubernetes-version }}_mnist.ipynb \
PAPERMILL_TIMEOUT=900
make test-e2e-notebook \
NOTEBOOK_INPUT=./examples/training/pytorch/question-answering/fine-tune-distilbert.ipynb \
NOTEBOOK_OUTPUT=./artifacts/notebooks/${{ matrix.kubernetes-version }}_fine-tune-distilbert.ipynb \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those should be imported from trainer repo, right?

Suggested change
NOTEBOOK_INPUT=./examples/training/pytorch/image-classification/mnist.ipynb \
NOTEBOOK_OUTPUT=./artifacts/notebooks/${{ matrix.kubernetes-version }}_mnist.ipynb \
PAPERMILL_TIMEOUT=900
make test-e2e-notebook \
NOTEBOOK_INPUT=./examples/training/pytorch/question-answering/fine-tune-distilbert.ipynb \
NOTEBOOK_OUTPUT=./artifacts/notebooks/${{ matrix.kubernetes-version }}_fine-tune-distilbert.ipynb \
NOTEBOOK_INPUT=./trainer/examples/pytorch/image-classification/mnist.ipynb \
NOTEBOOK_OUTPUT=./artifacts/notebooks/${{ matrix.kubernetes-version }}_mnist.ipynb \
PAPERMILL_TIMEOUT=900
make test-e2e-notebook \
NOTEBOOK_INPUT=./trainer/examples/pytorch/question-answering/fine-tune-distilbert.ipynb \
NOTEBOOK_OUTPUT=./artifacts/notebooks/${{ matrix.kubernetes-version }}_fine-tune-distilbert.ipynb \

Signed-off-by: Brian Gallagher <briangal@gmail.com>
@briangallagher
Copy link
Author

@Electronic-Waste @andreyvelich Workflow is waiting approval again.
Also, I think it got stuck in the queue the last time because the workflow is requesting ubuntu-latest-16-cores
I copied this config from the trainer repo so I presume it will be required to execute the notebooks successfully?
Can this 16 core image be approved and configured?

@tenzen-y
Copy link
Member

@Electronic-Waste @andreyvelich Workflow is waiting approval again. Also, I think it got stuck in the queue the last time because the workflow is requesting ubuntu-latest-16-cores I copied this config from the trainer repo so I presume it will be required to execute the notebooks successfully? Can this 16 core image be approved and configured?

Done.

e2e-test:
name: E2E Test
runs-on:
labels: ubuntu-latest-16-cores
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kubeflow/kubeflow-steering-committee could you enable this instance in this repository as well as other repositories?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add E2E tests for Kubeflow SDK
4 participants