-
Notifications
You must be signed in to change notification settings - Fork 12
add e2e notebook tests #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
add e2e notebook tests #27
Conversation
Signed-off-by: Brian Gallagher <briangal@gmail.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@andreyvelich Can you approve this workflow? |
/ok-to-test |
Makefile
Outdated
LOCALBIN ?= $(PROJECT_DIR)/bin | ||
|
||
# Tool versions | ||
KIND_VERSION ?= $(shell go list -m -f '{{.Version}}' sigs.k8s.io/kind) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have go.mod
in sdk repo, could just set a fallback value?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, will set to current version, v0.27.0, thanks
.github/workflows/test-e2e.yaml
Outdated
NOTEBOOK_INPUT=./examples/training/pytorch/image-classification/mnist.ipynb \ | ||
NOTEBOOK_OUTPUT=./artifacts/notebooks/${{ matrix.kubernetes-version }}_mnist.ipynb \ | ||
PAPERMILL_TIMEOUT=900 | ||
make test-e2e-notebook \ | ||
NOTEBOOK_INPUT=./examples/training/pytorch/question-answering/fine-tune-distilbert.ipynb \ | ||
NOTEBOOK_OUTPUT=./artifacts/notebooks/${{ matrix.kubernetes-version }}_fine-tune-distilbert.ipynb \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those should be imported from trainer repo, right?
NOTEBOOK_INPUT=./examples/training/pytorch/image-classification/mnist.ipynb \ | |
NOTEBOOK_OUTPUT=./artifacts/notebooks/${{ matrix.kubernetes-version }}_mnist.ipynb \ | |
PAPERMILL_TIMEOUT=900 | |
make test-e2e-notebook \ | |
NOTEBOOK_INPUT=./examples/training/pytorch/question-answering/fine-tune-distilbert.ipynb \ | |
NOTEBOOK_OUTPUT=./artifacts/notebooks/${{ matrix.kubernetes-version }}_fine-tune-distilbert.ipynb \ | |
NOTEBOOK_INPUT=./trainer/examples/pytorch/image-classification/mnist.ipynb \ | |
NOTEBOOK_OUTPUT=./artifacts/notebooks/${{ matrix.kubernetes-version }}_mnist.ipynb \ | |
PAPERMILL_TIMEOUT=900 | |
make test-e2e-notebook \ | |
NOTEBOOK_INPUT=./trainer/examples/pytorch/question-answering/fine-tune-distilbert.ipynb \ | |
NOTEBOOK_OUTPUT=./artifacts/notebooks/${{ matrix.kubernetes-version }}_fine-tune-distilbert.ipynb \ |
Signed-off-by: Brian Gallagher <briangal@gmail.com>
@Electronic-Waste @andreyvelich Workflow is waiting approval again. |
Done. |
e2e-test: | ||
name: E2E Test | ||
runs-on: | ||
labels: ubuntu-latest-16-cores |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kubeflow/kubeflow-steering-committee could you enable this instance in this repository as well as other repositories?
What this PR does / why we need it:
Add e2e tests to ensure that the sdk is still compatible with the latest version of trainer.
Which issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...
format, will close the issue(s) when PR gets merged):Fixes #18
Checklist: