Skip to content
This repository was archived by the owner on Sep 19, 2022. It is now read-only.

Migrate pytorch-operator to go modules #272

Merged
merged 7 commits into from
May 19, 2020

Conversation

Jeffwan
Copy link
Member

@Jeffwan Jeffwan commented May 18, 2020

  1. Update the project to use go modules
  2. Bump Kubernetes dependencies to 1.15.9 (which is the version k8s use go modules)
  3. Update update-codegen.sh, .travis.yml and Dockerfile

I will file a PR to remove vendor directory separately. Otherwise, it makes PR hard to review.

@Jeffwan Jeffwan requested review from johnugeorge and gaocegege May 18, 2020 21:44
@Jeffwan Jeffwan requested a review from hmtai May 18, 2020 21:44
@k8s-ci-robot k8s-ci-robot requested a review from andreyvelich May 18, 2020 21:44
@Jeffwan Jeffwan force-pushed the migrate_to_go_mod branch from 24765ed to baea67a Compare May 18, 2020 22:52
@Jeffwan
Copy link
Member Author

Jeffwan commented May 18, 2020

Seem presubmit test failed due to some dependency issues. The errors happens in test/e2e folder. I update vendor modules at this moment. While, the goal is to remove all vendor files.

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/assign @johnugeorge

@johnugeorge
Copy link
Member

/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 716986a into kubeflow:master May 19, 2020
@Jeffwan Jeffwan deleted the migrate_to_go_mod branch May 19, 2020 17:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants