Skip to content
This repository was archived by the owner on Sep 19, 2022. It is now read-only.

Delete v1alpha1 API and Controller #110

Merged
merged 2 commits into from
Nov 21, 2018

Conversation

johnugeorge
Copy link
Member

@johnugeorge johnugeorge commented Nov 20, 2018

Currently we only support last two versions of the operator - v1alpha2 and v1beta1

Fixes: #105


This change is Reviewable

@coveralls
Copy link

coveralls commented Nov 20, 2018

Coverage Status

Coverage increased (+6.5%) to 73.42% when pulling 5645218 on johnugeorge:delete-v1alpha1-api into 8d71ff3 on kubeflow:master.

@johnugeorge johnugeorge changed the title WIP: Delete v1alpha1 API and Controller Delete v1alpha1 API and Controller Nov 20, 2018
@johnugeorge
Copy link
Member Author

/assign @gaocegege

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit d33e8ed into kubeflow:master Nov 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants