Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin specific version of kubeflow instead of using master #995

Merged
merged 2 commits into from
Mar 30, 2019

Conversation

IronPan
Copy link
Member

@IronPan IronPan commented Mar 19, 2019

/assign @kunmingg


This change is Reviewable

@IronPan
Copy link
Member Author

IronPan commented Mar 19, 2019

/test kubeflow-pipeline-e2e-test

1 similar comment
@IronPan
Copy link
Member Author

IronPan commented Mar 19, 2019

/test kubeflow-pipeline-e2e-test

@vicaire vicaire removed their request for review March 21, 2019 00:09
@gaoning777
Copy link
Contributor

/lgtm

@gaoning777
Copy link
Contributor

/test kubeflow-pipeline-e2e-test

@Ark-kun Ark-kun changed the title ping specific version of kubeflow instead of from master Pin specific version of kubeflow instead of using master Mar 25, 2019
@Ark-kun
Copy link
Contributor

Ark-kun commented Mar 25, 2019

/test kubeflow-pipeline-e2e-test

@hongye-sun
Copy link
Contributor

/retest

@IronPan
Copy link
Member Author

IronPan commented Mar 25, 2019

The test failed might due to legit issue in the code. I'll look into it when possible

@Ark-kun
Copy link
Contributor

Ark-kun commented Mar 30, 2019

/lgtm

@IronPan
Copy link
Member Author

IronPan commented Mar 30, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 1fe8497 into master Mar 30, 2019
@IronPan IronPan deleted the IronPan-patch-2 branch May 30, 2019 07:16
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
…eflow#995)

* add big data passing with custom volume on kfp-tekton

* fix vscode typos and address errors

* Update compiler.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants