Add component.yaml to every ibm-components #984
Conversation
|
Hi @Tomcli. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1 similar comment
|
Hi @Tomcli. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign @animeshsingh |
| inputs: | ||
| - {name: model_id, description: 'Required. Model training_id from Fabric for Deep Learning'} | ||
| - {name: deployment_name, description: 'Required. Deployment name for the seldon service'} | ||
| - {name: model_class_name, description: 'PyTorch model class name', default: 'ModelClass'} |
There was a problem hiding this comment.
Is this specific to PyTorch models? Should we call this 'Seldon Core - Serve PyTorch Model' ? Or make it mroe generic?
There was a problem hiding this comment.
Thanks for the review. The component container itself could be more generic, but maybe this component.yaml implementation is more specific for PyTorch model. Let me rename the description.
| description: | | ||
| Deploy stored model on Watson Machine Learning as a web service. | ||
| inputs: | ||
| - {name: model_uid, description: 'Required. UID for the Watson Machine Learning model'} |
There was a problem hiding this comment.
Is this the UID for stored model?
There was a problem hiding this comment.
Yes, the Watson store component output will be passed to this field as model UID.
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: animeshsingh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/ok-to-test |
|
/lgtm |
…beflow#984 (kubeflow#985) * Add binary character check to copy-results-artifacts * Update unit tests
Add component.yaml to every ibm-components, so users can have a better idea about each component and able to load components with
kfp.components.This change is