Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: enabe back archiving experiment action in kfp_functional_test #9748

Merged
merged 5 commits into from
Aug 15, 2023
Merged

test: enabe back archiving experiment action in kfp_functional_test #9748

merged 5 commits into from
Aug 15, 2023

Conversation

difince
Copy link
Member

@difince difince commented Jul 18, 2023 •
edited
Loading

Description of your changes:
Enable back archiving experiment action in kfp_functional_test and upgrade to using kfp.v2

Resolves: #9770

Depends on PR: #9730

Checklist:

@difince
re-enabe archiving experiment action in kfp_functional_test
95419e9 
Signed-off-by: diana <difince@gmail.com>
@gkcalat gkcalat mentioned this pull request Jul 20, 2023
Closed
@difince
Use kfp.v2 instead of kfp.depricated
57124f6 
Signed-off-by: diana <difince@gmail.com>
@difince difince changed the title test: enabe back archiving experiment action in kfp_functional_test [WIP] test: enabe back archiving experiment action in kfp_functional_test Jul 24, 2023
@google-oss-prow google-oss-prow bot added size/L and removed size/M labels Aug 15, 2023
@difince difince changed the title [WIP] test: enabe back archiving experiment action in kfp_functional_test test: enabe back archiving experiment action in kfp_functional_test Aug 15, 2023
@gkcalat
Copy link
Member

gkcalat commented Aug 15, 2023

/retest

@google-oss-prow
Copy link

@difince: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kubeflow-pipeline-e2e-test e8c6c36 link true /test kubeflow-pipeline-e2e-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gkcalat gkcalat mentioned this pull request Aug 15, 2023
Closed
@gkcalat
Copy link
Member

gkcalat commented Aug 15, 2023

Sample tests failure is unrelated to this change.

/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Aug 15, 2023
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gkcalat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gkcalat gkcalat merged commit 7b4ddf6 into kubeflow:master Aug 15, 2023
1 check passed
@difince difince mentioned this pull request Sep 5, 2023
Closed
stijntratsaertit pushed a commit to stijntratsaertit/kfp that referenced this pull request Feb 16, 2024
@difince @gkcalat @stijntratsaertit
test: enabe back archiving experiment action in kfp_functional_test (k…
03f7b00 
…ubeflow#9748)

* re-enabe archiving experiment action in kfp_functional_test

Signed-off-by: diana <difince@gmail.com>

* Use kfp.v2 instead of kfp.depricated

Signed-off-by: diana <difince@gmail.com>

* Update periodic kfp_functional_test to work with kfp=2.0.1

Signed-off-by: diana <difince@gmail.com>

* Updata dependencies and clean up instructions

---------

Signed-off-by: diana <difince@gmail.com>
Co-authored-by: gkcalat <gkcalat@ucla.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkcalat gkcalat gkcalat left review comments

@jlyaoyuli jlyaoyuli Awaiting requested review from jlyaoyuli

Assignees

@chensun chensun

@gkcalat gkcalat

Labels
approved lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(test): Fix periodic functional tests
3 participants
@difince @gkcalat @chensun