Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing main_class arg to spark job and set default values. #966

Merged
merged 2 commits into from
Mar 14, 2019

Conversation

hongye-sun
Copy link
Contributor

@hongye-sun hongye-sun commented Mar 13, 2019

This change is Reviewable

@@ -27,12 +27,14 @@ inputs:
- name: cluster_name
description: 'Required. The cluster to run the job.'
- name: main_jar_file_uri
default: ''
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it really optional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, user can put the jar file path in the jarFileUris and specify the mainClass to point to the main entry.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, user can put the jar file path in the jarFileUris and specify the mainClass to point to the main entry.

@gaoning777
Copy link
Contributor

/lgtm

@hongye-sun
Copy link
Contributor Author

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongye-sun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongye-sun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit f7faf3e into kubeflow:master Mar 14, 2019
cheyang pushed a commit to alibaba/pipelines that referenced this pull request Mar 28, 2019
…flow#966)

* Add missing main_class arg to spark job and set default values.

* Adding missing main_class parameter passing.
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
* Adding release branch of training operator

* Remove obsolote branch
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants