Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set default values for payload objects in case of empty. #962

Merged
merged 1 commit into from
Mar 13, 2019
Merged

Set default values for payload objects in case of empty. #962

merged 1 commit into from
Mar 13, 2019

Conversation

hongye-sun
Copy link
Contributor

@hongye-sun hongye-sun commented Mar 12, 2019 •
edited by jlewi
Loading

This change is Reviewable

@gaoning777
Copy link
Contributor

/lgtm

@hongye-sun
Copy link
Contributor Author

/retest

@Ark-kun
Copy link
Contributor

Ark-kun commented Mar 12, 2019

/lgtm
Are those sections required in the request body?

@hongye-sun
Copy link
Contributor Author

Not required. That's why I add those checks to make sure the component is still working even the field is missing or empty.

@hongye-sun
Copy link
Contributor Author

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongye-sun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongye-sun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 2fc51bd into kubeflow:master Mar 13, 2019
cheyang pushed a commit to alibaba/pipelines that referenced this pull request Mar 28, 2019
@hongye-sun @k8s-ci-robot
Set default values for payload objects in case of empty. (kubeflow#962)
45d6a5b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ark-kun Ark-kun Awaiting requested review from Ark-kun

@gaoning777 gaoning777 Awaiting requested review from gaoning777

Assignees

@Ark-kun Ark-kun

@gaoning777 gaoning777

Labels
approved lgtm size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hongye-sun @gaoning777 @Ark-kun @k8s-ci-robot