Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend): upgrade to gopkg.in/yaml.v3 to fix boolean support. Fixes #9451 #9473

Merged
merged 1 commit into from
May 24, 2023

Conversation

chensun
Copy link
Member

@chensun chensun commented May 22, 2023

Description of your changes:

Upgrade to gopkg.in/yaml.v3 to avoid converting string "y" to boolean "true".
Fixes #9451

Checklist:

@chensun
Copy link
Member Author

chensun commented May 22, 2023

/hold

@chensun
Copy link
Member Author

chensun commented May 23, 2023

/unhold
/retest

@google-oss-prow
Copy link

google-oss-prow bot commented May 23, 2023

@chensun: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kubeflow-pipelines-samples-v2 20a877d link false /test kubeflow-pipelines-samples-v2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Linchin
Copy link
Contributor

Linchin commented May 23, 2023

Thank you @chensun!
/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label May 23, 2023
@chensun
Copy link
Member Author

chensun commented May 24, 2023

/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun, Linchin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 4810b7a into kubeflow:master May 24, 2023
@chensun chensun deleted the fix-yaml-parsing branch October 5, 2023 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Pipeline component input parameters has been altered from "y" to "true"
3 participants