Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK - Added support for loading zip-packed components #931

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Mar 7, 2019

The zip-packed components are supported in all load_component APIs:
kfp.components.load_component
kfp.components.load_component_from_file
kfp.components.load_component_from_url
kfp.components.ComponentStore.load_component

This change is Reviewable

Copy link
Contributor

@hongye-sun hongye-sun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

sdk/python/kfp/components/_components.py Outdated Show resolved Hide resolved
sdk/python/kfp/components/_components.py Outdated Show resolved Hide resolved
@Ark-kun Ark-kun force-pushed the Added-support-for-loading-zip-packed-components branch from d4d738d to f42ae2c Compare March 7, 2019 05:40
@k8s-ci-robot k8s-ci-robot removed the lgtm label Mar 7, 2019
The zip-packed components are supported in all load_component APIs:
kfp.components.load_component
kfp.components.load_component_from_file
kfp.components.load_component_from_url
kfp.components.ComponentStore.load_component
@Ark-kun Ark-kun force-pushed the Added-support-for-loading-zip-packed-components branch from f42ae2c to 6697117 Compare March 7, 2019 05:41
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Mar 7, 2019

@hongye-sun , can you re-LGTM please?

@hongye-sun
Copy link
Contributor

/lgtm

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Mar 7, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Ark-kun Ark-kun merged commit 6d080c7 into kubeflow:master Mar 7, 2019
@Ark-kun Ark-kun deleted the Added-support-for-loading-zip-packed-components branch March 7, 2019 22:46
@Ark-kun Ark-kun changed the title Added support for loading zip-packed components SDK - Added support for loading zip-packed components Mar 8, 2019
cheyang pushed a commit to alibaba/pipelines that referenced this pull request Mar 28, 2019
The zip-packed components are supported in all load_component APIs:
`kfp.components.load_component`
`kfp.components.load_component_from_file`
`kfp.components.load_component_from_url`
`kfp.components.ComponentStore.load_component`
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
)

Bumps [jinja2](https://github.com/pallets/jinja) from 2.11.2 to 2.11.3.
- [Release notes](https://github.com/pallets/jinja/releases)
- [Changelog](https://github.com/pallets/jinja/blob/master/CHANGES.rst)
- [Commits](pallets/jinja@2.11.2...2.11.3)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
* Update api docs

* Update doc

* Add newline

* update doc

* Fix CI test config

* Fix custom example data plane instruction
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants