Samples - Improved the TFX OSS notebook and README #922
Conversation
Addressed the issues described here: kubeflow#913
|
/approve |
|
/hold Holding this PR because it has a non-successful GitHub check which is preventing Tide from merging because Tide does not respect GitHub checks (only GitHub status contexts). This is blocking automated merge to this repo. |
@cjwagner |
Ark-kun
force-pushed
the
Improved-the-TFX-OSS-notebook-and-README
branch
from
777a022
to
e02f7c4
Compare
The check was in the pending state when I wrote that message. It appears to be successful now so Tide might be able to merge now. That being said Tide doesn't respect GH checks so the behavior is undefined and the checks really should not be enabled on this repo at all. I opened an issue for that: #930 |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ark-kun
changed the title
* Improved the TFX OSS notebook and README Addressed the issues described here: kubeflow#913 * Addressed the PR feedback.
Addressed the issues described here: #913
This change is