Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #916

Merged
merged 1 commit into from
Mar 6, 2019
Merged

Update README.md #916

merged 1 commit into from
Mar 6, 2019

Conversation

paveldournov
Copy link
Contributor

@paveldournov paveldournov commented Mar 5, 2019 •
edited by jlewi
Loading

This change is Reviewable

@Ark-kun
Copy link
Contributor

Ark-kun commented Mar 6, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Ark-kun
Copy link
Contributor

Ark-kun commented Mar 6, 2019

/test kubeflow-pipeline-e2e-test

@k8s-ci-robot
Copy link
Contributor

@paveldournov: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
kubeflow-pipeline-e2e-test 2edc6b1 link /test kubeflow-pipeline-e2e-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@paveldournov paveldournov merged commit dd1b11e into master Mar 6, 2019
cheyang pushed a commit to alibaba/pipelines that referenced this pull request Mar 28, 2019
@paveldournov
Update README.md (kubeflow#916)
093f907
@IronPan IronPan deleted the paveldournov-patch-1 branch June 28, 2019 18:48
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
@yhwang
fix(sdk): handle the node selectors (kubeflow#916)
eac02f0 
Handle the node selector info from PipelineConf in
compiler. Node selector info in Op level could overide
PipelinConf.
settings.

Signed-off-by: Yihong Wang <yh.wang@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaoning777 gaoning777 Awaiting requested review from gaoning777

@hongye-sun hongye-sun Awaiting requested review from hongye-sun

Assignees

@Ark-kun Ark-kun

Labels
approved lgtm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paveldournov @Ark-kun @k8s-ci-robot