-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass meta to containerop and pipeline #905
Pass meta to containerop and pipeline #905
Conversation
remove schema validators for GCRPath, and adjust for GCRPath, GCSPath change _check_valid_dict to _check_valid_type_dict to avoid confusion fix typo in the comments adjust function order for readability
update the _check_valid_type_dict name
GitHub diff seems to be glitching for me, so I'll write my commentt here: For We could make the result the same as in component yaml by doing the serialization like this:
But I'm fine with whatever you decide to do. |
Apart from my last comments, this looks pretty good to me. |
@Ark-kun I modified the TypeMeta to be serialized to both str and dict. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gaoning777 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gaoning777 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
pass metadata from python conf to containerop and the pipeline
* update tekton client to 0.31.4 * update tekton manifests * add missing go mod files
Pass the metadata from the component and pipeline to ContainerOp and Pipeline
This change is