Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move integration test to sub dir #888

Merged
merged 3 commits into from
Mar 1, 2019
Merged

move integration test to sub dir #888

merged 3 commits into from
Mar 1, 2019

Conversation

IronPan
Copy link
Member

@IronPan IronPan commented Mar 1, 2019

Move to a sub integration/ directory, to better structure the test for adding upgrade test
the structure would look like
backend/
--test/
----integration/
----upgrade/
----utils...


This change is Reviewable

@IronPan
Copy link
Member Author

IronPan commented Mar 1, 2019

/assign @neuromage @vicaire

@IronPan
Copy link
Member Author

IronPan commented Mar 1, 2019

/test kubeflow-pipeline-e2e-test

@vicaire
Copy link
Contributor

vicaire commented Mar 1, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vicaire

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vicaire

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit f8c1dde into master Mar 1, 2019
@IronPan IronPan deleted the retest branch March 27, 2019 17:55
cheyang pushed a commit to alibaba/pipelines that referenced this pull request Mar 28, 2019
* move integration test to sub dir

* revert
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
* add unit tests for recorder

* adding additional tests

* add ConditionReady and assume the empty == False

* move record events to controller

* resolve comments
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
Use KServe for the model serving

Signed-off-by: Yihong Wang <yh.wang@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants