Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support .zip pipeline package #874

Merged
merged 8 commits into from
Mar 1, 2019
Merged

support .zip pipeline package #874

merged 8 commits into from
Mar 1, 2019

Conversation

IronPan
Copy link
Member

@IronPan IronPan commented Feb 27, 2019

API would accept .zip, .tar.gz and plain yaml as the file format of a pipeline.


This change is Reviewable

@IronPan
Copy link
Member Author

IronPan commented Feb 27, 2019

/assign @yebrahim

@IronPan
Copy link
Member Author

IronPan commented Feb 27, 2019

/assign @gaoning777

backend/src/apiserver/server/util.go Outdated Show resolved Hide resolved
backend/src/apiserver/server/util.go Outdated Show resolved Hide resolved
backend/src/apiserver/server/util.go Show resolved Hide resolved
@jlewi jlewi removed their request for review February 28, 2019 04:53
@@ -0,0 +1,36 @@
# Copyright 2018 Google LLC
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How come we need a new sample for a new format? It seems the same one could be used for all formats.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i was having the source file and zipped file side by side so reader dont need to unzip file to know what is inside. but i think it's not necessary. removed

@yebrahim
Copy link
Contributor

nit: new files should have 2019 copyright headers.

@IronPan
Copy link
Member Author

IronPan commented Feb 28, 2019

update the copyright in #880

@vicaire
Copy link
Contributor

vicaire commented Feb 28, 2019

/lgtm
/approve

@yebrahim
Copy link
Contributor

Looks like there's a bunch of files that got their license headers update by mistake in this PR. Can we revert those? Only new files (ones created in 2019) should have the 2019 headers.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vicaire

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vicaire

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

@yebrahim yebrahim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 1bde255 into kubeflow:master Mar 1, 2019
cheyang pushed a commit to alibaba/pipelines that referenced this pull request Mar 28, 2019
* support zip

* update integration test

* debug

* comments

* fix

* Update .cloudbuild.yaml

* Update .release.cloudbuild.yaml

* Update .travis.yml
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants