-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support .zip pipeline package #874
Conversation
/assign @yebrahim |
/assign @gaoning777 |
@@ -0,0 +1,36 @@ | |||
# Copyright 2018 Google LLC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How come we need a new sample for a new format? It seems the same one could be used for all formats.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i was having the source file and zipped file side by side so reader dont need to unzip file to know what is inside. but i think it's not necessary. removed
nit: new files should have 2019 copyright headers. |
update the copyright in #880 |
/lgtm |
Looks like there's a bunch of files that got their license headers update by mistake in this PR. Can we revert those? Only new files (ones created in 2019) should have the 2019 headers. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vicaire The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vicaire The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
* support zip * update integration test * debug * comments * fix * Update .cloudbuild.yaml * Update .release.cloudbuild.yaml * Update .travis.yml
API would accept .zip, .tar.gz and plain yaml as the file format of a pipeline.
This change is