Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Presubmit tests - Added presubmit SDK Components tests to Travis #87

Merged

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Nov 6, 2018

This change is Reviewable

@Ark-kun Ark-kun force-pushed the avolkov/Added-presubmit-DSL-Components-tests-to-Travis branch from cadd571 to e906905 Compare November 9, 2018 21:41
@coveralls
Copy link

coveralls commented Nov 9, 2018

Pull Request Test Coverage Report for Build 169

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 67.592%

Totals Coverage Status
Change from base Build 167: 0.0%
Covered Lines: 1535
Relevant Lines: 2179

💛 - Coveralls

@Ark-kun Ark-kun force-pushed the avolkov/Added-presubmit-DSL-Components-tests-to-Travis branch from e906905 to 8d5dc08 Compare November 9, 2018 23:12
Copy link
Contributor

@qimingj qimingj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@qimingj
Copy link
Contributor

qimingj commented Nov 10, 2018

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qimingj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qimingj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 42bcde1 into master Nov 10, 2018
IronPan added a commit that referenced this pull request Nov 11, 2018
@Ark-kun Ark-kun deleted the avolkov/Added-presubmit-DSL-Components-tests-to-Travis branch January 15, 2019 22:10
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
…low#300)

* Create a cron job to regularly garbage collect test resources.

* Add to cleanup_ci.py an "all" subcommand to delete all resources."
* Add a batch job for one off runs.

Related to:
  kubeflow#87 Cron job to garbage collect test resources
  kubeflow#249 cron job to collect Kubeflow deployments launched by E2E tests

* * Add a cron job to run the cleanup every two hours.
* In cleanup_ci.py; don't load the imports of the manifests
  We encountered an error where the manifest didn't exist. I think
  that may have been a collision because we had a separate script running to do
  the deletes.

* Fix some bugs.

* Deal with config being none.

* Maybe activate service account.
HumairAK referenced this pull request in red-hat-data-services/data-science-pipelines Mar 11, 2024
Fix Unit Tests from updating busybox image in SDK
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants