Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor MLEngine code and add deploy and set_default commands #864

Merged
merged 4 commits into from
Mar 1, 2019

Conversation

hongye-sun
Copy link
Contributor

@hongye-sun hongye-sun commented Feb 27, 2019

The PR includes changes:

  • Add deploy and set_default commands
  • Refactor the model and version name to be the full API path to be consistent with the API representation.
  • Dump files in /tmp/kfp/output folder.

This change is Reviewable

@gaoning777
Copy link
Contributor

/lgtm

@hongye-sun
Copy link
Contributor Author

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongye-sun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongye-sun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hongye-sun
Copy link
Contributor Author

Thanks for the review and great comments.

@k8s-ci-robot k8s-ci-robot merged commit 17bb778 into kubeflow:master Mar 1, 2019
cheyang pushed a commit to alibaba/pipelines that referenced this pull request Mar 28, 2019
…low#864)

* Refactor MLEngine code and add deploy and set_default commands

* Rename to short name to avoid confusion.

* Add comment to version names

* Rename short name to id
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
* Add optional-test-infra-tekton resources

* Add optional-test-infra-tekton resources
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
* add test for empty loops

* treat no-tasks and tasks-list-empty the same

* add licenses
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants