Fixing grammatical errors and references

[animeshsingh]

This change is 

[k8s-ci-robot]

Hi @animeshsingh. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

Hi @animeshsingh. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[gaoning777]

/ok-to-test

[hongye-sun]

/lgtm

[animeshsingh]

Thanks @hongye-sun. Can this be merged?

[hongye-sun]

/retest

[hongye-sun]

I think you already have the approval permission. Could you try to approve by yourself?

[hongye-sun]

I can also approve but just want to verify that the OWNERS file under the ibm-samples directory is working. Let me know if you still need my approval. Thanks.

[animeshsingh]

/approve

[k8s-ci-robot]

@animeshsingh: you cannot LGTM your own PR.

In response to this:

/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

@animeshsingh: you cannot LGTM your own PR.

In response to this:

/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[animeshsingh]

So @hongye-sun when add the label to approve, seems it still needs an additional approver. So that means the OWNERS file isn`t working?

"This pull-request has been approved by: animeshsingh
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: hongye-sun"

[animeshsingh]

/assign @hongye-sun

[animeshsingh]

@vicaire is the OWNERS file in here not working? Or an OWNER cannot get his own PR in once reviewed by a reviewer?

[hongye-sun]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: animeshsingh, hongye-sun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• samples/OWNERS [hongye-sun]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: animeshsingh, hongye-sun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• samples/OWNERS [hongye-sun]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[hongye-sun]

@animeshsingh, sorry for the delay, I missed your last message. I don't quite understand why the OWNER file doesn't work here. Usually, I can approve my own PR if it's LGTMed by others.

[animeshsingh]

Thanks @hongye-sun. Who can we discuss this with? Also would love to get in the OWNERS file for 'samples' repo, even if i will just exercise it on ibm-samples?

[hongye-sun]

@vicaire and @IronPan , do you have any insight on this?

[vicaire]

Hi @animeshsingh,

I think you just need someone else to LGTM your PR. It could be someone from your team or one of us. The comments above from k8-ci-robot list what was missing at each iteration. It may be the same for /approve. You might have to add an approver from your team to the OWNER file.

(Note: please make sure not to check-in any binaries)

About granting "approve" on the whole "sample" directory, could you suggest instead how we could reorganize the code so that you are not blocked?

[animeshsingh]

@vicaire LGTM was already added by @hongye-sun - still this does not get in... so the thing missing someone else saying /approve as well?

[vicaire]

@animeshsingh. That's my guess: when you approved, the robot answered that you cannot LGTM your own PR (maybe it should have said that you cannot "approve" your own PR).

Note that we are using the Kubernetes bot. Looking at the code could help figure out the exact behavior.
https://github.com/oracle/kubernetes-test-infra/blob/master/commands.md

I would suggest to have a second approver. If it does not work, we can investigate further.