-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
merge build image to test suit #799
Conversation
/assign @gaoning777 |
cc @krzyzacy |
Do you want to split up the unified job into multiple jobs then? |
@krzyzacy yup that's the plan. please check pr description see if i miss anything. |
/lgtm |
This is part 2 of the test split for context see kubeflow/pipelines#799
/test kubeflow-pipeline-presubmit |
/retest |
maybe close/reopen the PR to get a clearer state? |
/close |
@IronPan: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1 similar comment
@IronPan: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
@IronPan: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IronPan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IronPan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is part 2 of the test split for context see kubeflow/pipelines#799
* test: fix cleanup blueprints script * fix2 * fix3 * fix Makefile, update ACM repo, add dryrun=false
Due to kubernetes/test-infra#11197
we need to move build image step to individual test suit.
Steps:
This change is