Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDK - Added support for raw input artifact argument values to ContainerOp #791

Merged
merged 11 commits into from
Aug 29, 2019
Merged

SDK - Added support for raw input artifact argument values to ContainerOp #791

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
ea04348
SDK - Added support for raw artifact values to ContainerOp
Ark-kun Feb 7, 2019
6fa15fd
`ContainerOp` now gets artifact artguments from command line instead …
Ark-kun Jun 19, 2019
c532b76
Added back input_artifact_arguments to the ContainerOp constructor.
Ark-kun Jun 19, 2019
665aa20
Exporting InputArtifactArgument from kfp.dsl
Ark-kun Jun 19, 2019
9aa5da7
Updated the sample
Ark-kun Jun 19, 2019
bc2d916
Properly passing artifact arguments as task arguments
Ark-kun Jun 19, 2019
6bd95bd
Renamed input_artifact_arguments to artifact_arguments to reduce conf…
Ark-kun Jun 19, 2019
4ab43ec
Renamed InputArtifactArgument to InputArgumentPath
Ark-kun Aug 28, 2019
3d4829e
Replaced getattr with isinstance checks.
Ark-kun Aug 29, 2019
16de4dc
Fixed the type annotations
Ark-kun Aug 29, 2019
4744e92
Unlocked the input artifact support in components
Ark-kun Aug 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Renamed input_artifact_arguments to artifact_arguments to reduce conf… 
…usion
  • Loading branch information
@Ark-kun
Ark-kun committed Aug 28, 2019
commit 6bd95bd48757fdc2121294efa08e5a46685c7c44
2 changes: 1 addition & 1 deletion sdk/python/kfp/compiler/compiler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -516,7 +516,7 @@ def _group_to_dag_template(self, group, inputs, outputs, dependencies):
arguments.sort(key=lambda x: x['name'])
task['arguments'] = {'parameters': arguments}

artifact_arguments = getattr(sub_group, 'input_artifact_arguments', None)
artifact_arguments = getattr(sub_group, 'artifact_arguments', None)
if artifact_arguments:
artifact_argument_structs = []
for input_name, argument in artifact_arguments.items():
Expand Down
2 changes: 1 addition & 1 deletion sdk/python/kfp/dsl/_container_op.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1077,7 +1077,7 @@ def _decorated(*args, **kwargs):

# attributes specific to `ContainerOp`
self.input_artifact_paths = input_artifact_paths
self.input_artifact_arguments = artifact_arguments
self.artifact_arguments = artifact_arguments
self.file_outputs = file_outputs
self.output_artifact_paths = output_artifact_paths or {}
self.artifact_location = artifact_location
Expand Down