-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds a modifier function to simplify addition of local volumes to containerop #783
Conversation
/cc @ramdootp |
/assign @Ark-kun |
@swiftdiaries, what do you think of the proposal at #801? |
change function name to mount_pvc
e4ecf7e
to
60f9006
Compare
/lgtm |
1 similar comment
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks for the review @Ark-kun ! |
change function name to mount_pvc
The normal method of adding volumes to containerop involves 3 steps
Like this:
This is fairly verbose.
With this change, we can add volumes from the DSL and we don't have to interact with the k8s client.
Syntax now:
This is much more readable and enables better reuse of volumes across different steps.
This change is