update developer guide to renew deployment section #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @IronPan |
jinchihe
force-pushed
the
update_developer_guide
branch
from
c5ded6f
to
ea590eb
Compare
|
@IronPan, could you please have a look? |
|
thank you @jinchihe |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IronPan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Maybe duplicated with #770 |
|
Thanks @IronPan |
Linchin
pushed a commit
to Linchin/pipelines
that referenced
this pull request
Apr 11, 2023
* add py unittests tekton run * disable lint messages based on tests * try fixing syntax error * revert and disable syntax-error * ignore specific line lints * resolve run_e2e_workflow lint * remove ks workflow condition * remove tests related to _get_actual_junit_files * resolve f string for python2 * reformat the string * remove unnecessary pipfile * fix logging string in get_kf_testing_cluster module * skip test for e2e workflow * delete e2e workflow test * remove unused import * add todo issues in the plintrc file
HumairAK
pushed a commit
to red-hat-data-services/data-science-pipelines
that referenced
this pull request
Mar 11, 2024
* add uid into big data passing midpath and update uid replacement to also replace with Tekton uid variable * use taskrun name as midpath * regenerate tests * fix tests * fix tests * fix lint * fix tests * update midpath from uid to original pipelinerun * fix lint * replace original pipelinerun name in api to make metadata writer to work. Also add big data passing format to pipeline annotations * update sdk loop logic to pass workspaces to sub-pipelines * fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old deployment way (bootstrapper.yaml/deploy.sh) has been removed, the pipeline is included in kubeflow now, but the developer guide is not updated accordingly.
The PR to renew the deployment section.
This change is