Add Launcher module in component SDK #769
Conversation
hongye-sun
changed the title
hongye-sun
force-pushed
the
sdk-launcher
branch
from
de8e3ca
to
742242f
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vicaire The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vicaire The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
/test kubeflow-pipeline-e2e-test |
|
/retest |
|
/test kubeflow-pipeline-presubmit |
|
/skip |
|
/override kubeflow-pipeline-e2e-test |
|
/test kubeflow-pipeline-e2e-test |
|
/test kubeflow-pipeline-presubmit |
|
/override kubeflow-pipeline-e2e-test |
|
/retest |
|
@hongye-sun: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest |
|
/test kubeflow-pipeline-presubmit |
|
/close |
|
@hongye-sun: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1 similar comment
|
@hongye-sun: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/reopen |
|
@hongye-sun: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@hongye-sun: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/skip |
|
oh hummm we deleted the |
|
/override kubeflow-pipeline-presubmit |
|
hummm can anyone that has admin in kubeflow run a https://github.com/kubernetes/test-infra/tree/master/maintenance/migratestatus to retire the |
|
(/override didn't work because that's not enabled in kubeflow org, feel free to also add that to https://github.com/kubernetes/test-infra/blob/master/prow/plugins.yaml#L309-L322) |
|
Thanks, Sen. @IronPan, do you mind retiring kubeflow-pipeline-presubmit? |
* add tekton pipelinerun for unittest kubeflow#769 * add pipeline yamls * fix pipelinespec indendatation * add tasks to get installed * update the running pipelinerun and add hydrated yamls * correct gcs path * update .pylintrc to ignore over the tests written * comment out tests using _get_actual_junit_files function * update rcfile complete path * add hydrated py-lint update * revert lint and uncomment out tests * use gcr image with sha only
Added a dynamic python fire launcher module which can be used as entrypoint to KFP components.
This will be used by GCP component as a single entrypoint to run all gcp commands.
For example, in mlengine create job spec:
python -m kfp_component.launcher kfp_component.google.ml_engine create_job --project <project> --job <job_payload>The same entrypoint can also be used to launch from arbitrary python file. After argo artifact raw content store is supported, user can directly put python function as a file in container and use the same entrypoint to launch it:
python -m kfp_component.launcher /tmp/script.py my_func --param1 <p1> --param2 <p2>This change is