Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add component_sdk tests to travis tests #761

Merged
merged 22 commits into from
Feb 1, 2019
Merged

Conversation

hongye-sun
Copy link
Contributor

@hongye-sun hongye-sun commented Feb 1, 2019

Same as #752

I accidentally closed the original one.


This change is Reviewable

@IronPan
Copy link
Member

IronPan commented Feb 1, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hongye-sun
Copy link
Contributor Author

/retest kubeflow-pipeline-e2e-test

@hongye-sun
Copy link
Contributor Author

/test kubeflow-pipeline-e2e-test

@Ark-kun
Copy link
Contributor

Ark-kun commented Feb 1, 2019

I accidentally closed the original one.

Usually you can "/reopen" closed pull requests...

@k8s-ci-robot k8s-ci-robot merged commit ef851e8 into kubeflow:master Feb 1, 2019
@hongye-sun
Copy link
Contributor Author

Ah, didn't know that. Will try it next time. Thanks.

Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
* Typo in README.txt INGRESS_GATEWAY is a variable

* Namespace for samples cannot be default namespace

When I apply the imagenet.yaml (kubectl create -f imagenet.yaml), I get the error 
Error from server: error when creating "imagenet.yaml": admission webhook "inferenceservice.kfserving-webhook-server.validator" denied the request: Cannot create the Inferenceservice "imagenet" in namespace "default": the namespace lacks label "serving.kubeflow.org/inferenceservice: enabled"


I guess that the inferenceservice must be applied in the <user_namespace> (as the other samples)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants