-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add component_sdk tests to travis tests #761
Conversation
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IronPan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IronPan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest kubeflow-pipeline-e2e-test |
/test kubeflow-pipeline-e2e-test |
Usually you can "/reopen" closed pull requests... |
Ah, didn't know that. Will try it next time. Thanks. |
* Typo in README.txt INGRESS_GATEWAY is a variable * Namespace for samples cannot be default namespace When I apply the imagenet.yaml (kubectl create -f imagenet.yaml), I get the error Error from server: error when creating "imagenet.yaml": admission webhook "inferenceservice.kfserving-webhook-server.validator" denied the request: Cannot create the Inferenceservice "imagenet" in namespace "default": the namespace lacks label "serving.kubeflow.org/inferenceservice: enabled" I guess that the inferenceservice must be applied in the <user_namespace> (as the other samples)
Same as #752
I accidentally closed the original one.
This change is