Add UI actions to Buttons module #758
Conversation
| disabledTitle: 'Run schedule already disabled', | ||
| id: 'disableBtn', | ||
| title: 'Disable', | ||
| tooltip: 'Disable the run\'s trigger', |
There was a problem hiding this comment.
nit: maybe "Prevent[/Stop] this from scheduling[/creating] additional runs"
There was a problem hiding this comment.
@ajayalfred what do you think of this suggestion? I also think it can use a little clearing.
| } catch (err) { | ||
| unsuccessfulIds.push(id); | ||
| const errorMessage = await errorToMessage(err); | ||
| errorMessages.push(`Failed to ${actionName.toLowerCase()} ${resourceName}: ${id} with error: "${errorMessage}"`); |
There was a problem hiding this comment.
thought: making the action name uppercase would better indicate the generality of it, but maybe we don't want that.
There was a problem hiding this comment.
Right now it reads nicely as "Failed to delete pipeline: id with error..." which I think is nicer than if it starts with a capital letter.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rileyjbauer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rileyjbauer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
listing images shouldn't fail the build. update the script to ignore the return value of those commands. Signed-off-by: Yihong Wang <yh.wang@ibm.com>
This PR refactors button action methods into the
Buttonsmodule, which fixes a few bugs, and allows for sharing common functionality.This change is