New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support pipeline level imagepullsecret in DSL #745

Merged

k8s-ci-robot merged 3 commits into kubeflow:master from gaoning777:dsl-imagepull-secret

Feb 5, 2019

Contributor

gaoning777 commented Jan 28, 2019 •

edited by jlewi

Loading

This change is


          support pipeline level imagepullsecret in DSL

k8s-ci-robot requested review from Ark-kun and hongye-sun

January 28, 2019 19:39

k8s-ci-robot added size/L labels

gaoning777 mentioned this pull request

Not using secret when pulling from private Registry #695

Closed

hongye-sun reviewed

View reviewed changes

sdk/python/kfp/dsl/_pipeline.py Outdated Show resolved Hide resolved

hongye-sun reviewed

View reviewed changes

sdk/python/kfp/dsl/_pipeline.py Outdated Show resolved Hide resolved

hongye-sun reviewed

View reviewed changes

sdk/python/kfp/dsl/_pipeline.py Outdated Show resolved Hide resolved

hongye-sun reviewed

View reviewed changes

sdk/python/kfp/dsl/_pipeline.py Outdated Show resolved Hide resolved

hongye-sun reviewed

View reviewed changes

sdk/python/tests/compiler/testdata/imagepullsecret.py Outdated Show resolved Hide resolved


          use kubernetes native input parameter for imagepullsecrets

cfa04bd

Ark-kun reviewed

View reviewed changes

sdk/python/tests/compiler/testdata/imagepullsecret.py Show resolved Hide resolved

Ark-kun reviewed

View reviewed changes

sdk/python/tests/compiler/testdata/imagepullsecret.py Show resolved Hide resolved

Ark-kun reviewed

View reviewed changes

sdk/python/kfp/dsl/_pipeline.py Outdated Show resolved Hide resolved


          expose a module level function to configure the pipeline settings for…

a5b9e7d

… the current default pipeline

Contributor

hongye-sun commented Feb 5, 2019

Thanks for the change.

/lgtm

k8s-ci-robot assigned hongye-sun

k8s-ci-robot added the lgtm label

Contributor Author

gaoning777 commented Feb 5, 2019

/approve

Contributor

k8s-ci-robot commented Feb 5, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaoning777

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~sdk/OWNERS~~ [gaoning777]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added the approved label

Contributor

k8s-ci-robot commented Feb 5, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaoning777

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~sdk/OWNERS~~ [gaoning777]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot merged commit 9ebbaa3 into kubeflow:master

Linchin pushed a commit to Linchin/pipelines that referenced this pull request


          Fix bad link of Playbook (kubeflow#745)

5d42a57

magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request


          fix(roadmap): Fix the date typo (kubeflow#745)

4f32741

Signed-off-by: Ce Gao <gaoce@caicloud.io>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm size/L