chore(backend): clean up pipelinespec.Value usage #7407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chensun, Linchin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
chensun
added a commit
to chensun/pipelines
that referenced
this pull request
Mar 15, 2022
google-oss-prow bot
pushed a commit
that referenced
this pull request
Mar 15, 2022
* copy _client.py and _auth.py from deprecated folder * Make kfp.Client support v2 API (IR). * fix test golden * address comments * copyright year * chore(backend): clean up pipelinespec.Value usage (#7407) * chore(sdk): clean, dedup, reconcile, organize requirements (#7400) * chore(sdk): clean, dedup, reconcile, organize requirements * apply yapf formatting * correct copyright * chore(sdk): fix test missing tempdir cleanup (#7403) * chore(sdk): fix test missing tempdir cleanup * fix test path * fix test path * clean up setUp method * change string placeholder from s to test_dir * release note Co-authored-by: Connor McCarthy <mccarthy.connor.james@gmail.com>
abaland
pushed a commit
to abaland/pipelines
that referenced
this pull request
May 29, 2022
abaland
pushed a commit
to abaland/pipelines
that referenced
this pull request
May 29, 2022
* copy _client.py and _auth.py from deprecated folder * Make kfp.Client support v2 API (IR). * fix test golden * address comments * copyright year * chore(backend): clean up pipelinespec.Value usage (kubeflow#7407) * chore(sdk): clean, dedup, reconcile, organize requirements (kubeflow#7400) * chore(sdk): clean, dedup, reconcile, organize requirements * apply yapf formatting * correct copyright * chore(sdk): fix test missing tempdir cleanup (kubeflow#7403) * chore(sdk): fix test missing tempdir cleanup * fix test path * fix test path * clean up setUp method * change string placeholder from s to test_dir * release note Co-authored-by: Connor McCarthy <mccarthy.connor.james@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
Checklist: