Add Dockerfile for building Viewer CRD controller. #740
Conversation
Also build it as part of the CloudBuild process.
|
/assign @IronPan |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IronPan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IronPan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
.cloudbuild.yaml
Outdated
| @@ -59,6 +63,7 @@ steps: | |||
| '--build-arg', 'SCHEDULED_WORKFLOW_IMAGE=gcr.io/$PROJECT_ID/scheduledworkflow:$COMMIT_SHA', | |||
| '--build-arg', 'PERSISTENCE_AGENT_IMAGE=gcr.io/$PROJECT_ID/persistenceagent:$COMMIT_SHA', | |||
| '--build-arg', 'UI_IMAGE=gcr.io/$PROJECT_ID/frontend:$COMMIT_SHA', | |||
| '--build-arg', 'VIEWER_CRD_CONTROLLER_IMAGE=gcr.io/$PROJECT_ID/viewer-crd-controller:$COMMIT_SHA', | |||
There was a problem hiding this comment.
just FYI this would be ignored as the arg is not defined here
https://github.com/kubeflow/pipelines/blob/master/pipeline/Dockerfile#L37
However it's probably fine since we might deprecate bootstrapper soon.
There was a problem hiding this comment.
Oh yeah, good point. I removed it, so as not to mess up potential merge conflicts.
|
/lgtm |
|
/retest |
|
/test kubeflow-pipeline-e2e-test |
* Now that we are using kptfiles; kpt will complain if we try to set a setter which doesn't exist. related to GoogleCloudPlatform/kubeflow-distribution#89
Also build it as part of the CloudBuild process.
This change is